<html>
<head><meta charset="utf-8"><title>failing CI notifications · t-compiler/wg-rustc-dev-guide · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/index.html">t-compiler/wg-rustc-dev-guide</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html">failing CI notifications</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204936188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204936188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204936188">(Jul 24 2020 at 16:23)</a>:</h4>
<p>I've been getting emails every few days from rustc-dev-guide's Travis CI for a commit that got merged a while ago - linking to <a href="https://travis-ci.com/github/rust-lang/rustc-dev-guide/builds/177055975">builds like this</a> - how can I stop these?</p>



<a name="204936492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204936492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204936492">(Jul 24 2020 at 16:25)</a>:</h4>
<p>maybe we should just whitelist github in the linkchecker?</p>



<a name="204936555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204936555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204936555">(Jul 24 2020 at 16:26)</a>:</h4>
<p>the constant 429s make it impossible to notice actual link failures</p>



<a name="204937761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204937761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204937761">(Jul 24 2020 at 16:35)</a>:</h4>
<p>I'm surprised there is a cron build for that old commit?</p>



<a name="204938239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204938239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204938239">(Jul 24 2020 at 16:40)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204936492">said</a>:</p>
<blockquote>
<p>maybe we should just whitelist github in the linkchecker?</p>
</blockquote>
<p>well, github link is sometimes broken e.g. changed the file path so it's still useful for us</p>



<a name="204938552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204938552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204938552">(Jul 24 2020 at 16:42)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116107">davidtwco</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204937761">said</a>:</p>
<blockquote>
<p>I'm surprised there is a cron build for that old commit?</p>
</blockquote>
<p>just for finding broken links iiuc, and it is not "old" commit, it's the latest on master</p>



<a name="204938756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204938756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204938756">(Jul 24 2020 at 16:45)</a>:</h4>
<p>so, we have config for notifications: <a href="https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L21-L23">https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L21-L23</a></p>
<p>I think we could just turn off the notifications whenever if no one uses it</p>



<a name="204938914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204938914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204938914">(Jul 24 2020 at 16:46)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217081">Yuki Okushi</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204938552">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116107">davidtwco</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204937761">said</a>:</p>
<blockquote>
<p>I'm surprised there is a cron build for that old commit?</p>
</blockquote>
<p>just for finding broken links iiuc, and it is not "old" commit, it's the latest on master</p>
</blockquote>
<p>oh, I assumed that stuff had been merged since - that makes sense</p>



<a name="204938979"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204938979" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204938979">(Jul 24 2020 at 16:47)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="1380">@WG-rustc-dev-guide</span> --^^ thoughts?</p>



<a name="204954492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204954492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204954492">(Jul 24 2020 at 19:04)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204936555">said</a>:</p>
<blockquote>
<p>the constant 429s make it impossible to notice actual link failures</p>
</blockquote>
<p>couldn't maybe we filter those out? or keep as errors 50x, 404 and the rest of the status codes that make sense for us?</p>



<a name="204954711"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204954711" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204954711">(Jul 24 2020 at 19:06)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217081">Yuki Okushi</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204938756">said</a>:</p>
<blockquote>
<p>so, we have config for notifications: <a href="https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L21-L23">https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L21-L23</a></p>
<p>I think we could just turn off the notifications whenever if no one uses it</p>
</blockquote>
<p>this also seems ok to me :)</p>



<a name="204955165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204955165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204955165">(Jul 24 2020 at 19:10)</a>:</h4>
<p>Regarding emails... I'm not sure why you are getting them... _I'm not getting any emails for CI failures_</p>



<a name="204955284"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204955284" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204955284">(Jul 24 2020 at 19:12)</a>:</h4>
<p>I suppose we could add somethign here: <a href="https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L23">https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L23</a></p>



<a name="204955287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204955287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204955287">(Jul 24 2020 at 19:12)</a>:</h4>
<p>?</p>



<a name="204956722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204956722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204956722">(Jul 24 2020 at 19:27)</a>:</h4>
<p><span class="user-mention silent" data-user-id="198054">mark-i-m</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204955284">said</a>:</p>
<blockquote>
<p>I suppose we could add somethign here: <a href="https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L23">https://github.com/rust-lang/rustc-dev-guide/blob/fd458b988ced462f4390a0a62abdb6e8993f98b5/.travis.yml#L23</a></p>
</blockquote>
<p>yep, I'm happy to submit a PR if we agree to do so</p>



<a name="204956842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204956842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204956842">(Jul 24 2020 at 19:28)</a>:</h4>
<p>It seems like a reasonable idea to me. I'm not aware that anyone actively wants the emails (but I might be wrong)</p>



<a name="204956875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204956875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204956875">(Jul 24 2020 at 19:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="198054">mark-i-m</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204955165">said</a>:</p>
<blockquote>
<p>Regarding emails... I'm not sure why you are getting them... _I'm not getting any emails for CI failures_</p>
</blockquote>
<p>IIRC it depends on their own settings: <a href="https://travis-ci.com/account/preferences">https://travis-ci.com/account/preferences</a></p>



<a name="204957011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204957011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204957011">(Jul 24 2020 at 19:30)</a>:</h4>
<p>Ah, I didn't know about that</p>



<a name="204957620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204957620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204957620">(Jul 24 2020 at 19:37)</a>:</h4>
<p>agree with the solution, but ...</p>



<a name="204957646"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204957646" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204957646">(Jul 24 2020 at 19:37)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116266">Santiago Pastorino</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204954492">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204936555">said</a>:</p>
<blockquote>
<p>the constant 429s make it impossible to notice actual link failures</p>
</blockquote>
<p>couldn't maybe we filter those out? or keep as errors 50x, 404 and the rest of the status codes that make sense for us?</p>
</blockquote>
<p>wouldn't make sense as a more long term solution to filter by status code like <span aria-label="point up" class="emoji emoji-1f446" role="img" title="point up">:point_up:</span> ?</p>



<a name="204957785"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204957785" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204957785">(Jul 24 2020 at 19:39)</a>:</h4>
<p>yeah, I also think it's better, actually, we've done similar work on the link checker on rust-lang/rust</p>



<a name="204957816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204957816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204957816">(Jul 24 2020 at 19:39)</a>:</h4>
<p>I think what I've said is not correct, maybe for now we just want to assume that 429 is like a 200 and done</p>



<a name="204957887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204957887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204957887">(Jul 24 2020 at 19:40)</a>:</h4>
<p>in the sense that we don't fail with them</p>



<a name="204957900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204957900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204957900">(Jul 24 2020 at 19:40)</a>:</h4>
<p>it seems okay for me</p>



<a name="204958576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204958576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204958576">(Jul 24 2020 at 19:46)</a>:</h4>
<p>silly question but is the link checker using <code>HEAD</code> for the requests? That would be less work on github's end, maybe they have different rate-limits for it</p>



<a name="204969299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204969299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204969299">(Jul 24 2020 at 21:33)</a>:</h4>
<p>hm interesting but I really don't know, I guess <span class="user-mention" data-user-id="244164">@Michael Bryan</span> is familiar with that?</p>



<a name="204975739"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204975739" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Michael Bryan <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204975739">(Jul 24 2020 at 23:15)</a>:</h4>
<p>It sounds like <a href="https://github.com/Michael-F-Bryan/mdbook-linkcheck/pull/35">the advanced error handling PR</a> would help here (<a href="https://github.com/Michael-F-Bryan/mdbook-linkcheck/issues/12">issue</a>)</p>



<a name="204975757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204975757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Michael Bryan <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204975757">(Jul 24 2020 at 23:16)</a>:</h4>
<p>The idea is you could specify how a link check failure is handled, so a 429 might just be a warning, 404 an error, etc</p>



<a name="204975810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204975810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Michael Bryan <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204975810">(Jul 24 2020 at 23:16)</a>:</h4>
<p>That way a bunch of 429s won't fail the build, giving the link checker a chance to fill it's cache and not hit the rate limit</p>



<a name="204975914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204975914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Michael Bryan <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204975914">(Jul 24 2020 at 23:18)</a>:</h4>
<p>And the link checker itself <a href="https://github.com/Michael-F-Bryan/linkcheck/blob/2f353b90e286cf6d881e42a5eb63e35c9ae096b2/src/validation/web.rs#L35">sends GET requests</a></p>



<a name="204976817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing%20CI%20notifications/near/204976817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/failing.20CI.20notifications.html#204976817">(Jul 24 2020 at 23:37)</a>:</h4>
<p>sent a PR to use HEAD instead :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>